Go back home before navigating to Concierge#33744
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hi @dukenv0307 , can you elaborate on test steps?
Why do we need set up a welcome message?
If in step 5 specify in mobile device, how can we test in Web/Desktop? Or it's impossible to test on those platforms?
Can you specify about how can we close Concierge chat in this step? Thanks |
|
@hoangzinh Updated test steps. |
|
I think we can move step 1->4 as pre-requisite steps, the main test steps is from step 5 |
|
@hoangzinh Updated. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-29.at.22.32.33.android.movAndroid: mWeb ChromeScreen.Recording.2023-12-29.at.21.50.23.-.android.chrome.moviOS: NativeScreen.Recording.2023-12-29.at.22.01.09.-.ios.moviOS: mWeb SafariScreen.Recording.2023-12-29.at.22.02.51.-.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2023-12-29.at.21.48.25.-.web.movMacOS: DesktopScreen.Recording.2023-12-29.at.21.58.50.desktop.mov |
| const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]); | ||
| const chat = ReportUtils.getChatByParticipants(participantAccountIDs); | ||
| if (chat?.reportID) { | ||
| Navigation.goBack(ROUTES.HOME); |
There was a problem hiding this comment.
can we add a comment why we're doing this? it looks confusing for someone unfamiliar with the issue
There was a problem hiding this comment.
@youssef-lr I just added comment. Please check again.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.22-0 🚀
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.22-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀
|
Details
Fixed Issues
$ #33521
PROPOSAL: #33521 (comment)
Tests
Pre-requisite steps: Create a room in a workspace with visibility as
Workspaceand invite some users to this workspace roomOffline tests
QA Steps
Pre-requisite steps: Create a room in a workspace with visibility as
Workspaceand invite some users to this workspace roomPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
a-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
i-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov